Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "tools: refactor tools/license2rtf to ESM" #43214

Merged
merged 1 commit into from
May 26, 2022

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented May 26, 2022

This reverts commit 30cb1bf.

Fixes: #43213
Refs: #43101

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels May 26, 2022
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. revert PRs that revert previously landed PRs. and removed windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. needs-ci PRs that need a full CI run. labels May 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2022
@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels May 26, 2022
@richardlau
Copy link
Member Author

I've added dont-land-* labels to #43101 so adding the same here as we don't need to revert if the original doesn't land in the staging branches 🙂.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 26, 2022

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label May 26, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 26, 2022
@nodejs-github-bot nodejs-github-bot merged commit 331088f into nodejs:master May 26, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 331088f

@richardlau richardlau deleted the revert43101 branch May 26, 2022 16:09
danielleadams pushed a commit that referenced this pull request Jun 11, 2022
This reverts commit 30cb1bf.

PR-URL: #43214
Fixes: #43213
Refs: #43101
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. revert PRs that revert previously landed PRs. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows build break: Failed to generate license.rtf
6 participants